jborean93 / pypsrp

PowerShell Remoting Protocol for Python
MIT License
327 stars 49 forks source link

Fix up outgoing fragment buffering #151

Closed jborean93 closed 2 years ago

jborean93 commented 2 years ago

If buffering data on a send operation there could be a scenario where the buffer is not completely full but there still remains data to be sent. If the call to pool.data_to_send has a size that is less than 21 it will fail because it's not large enough to contain the fragment itself. This just ensures that the buffering will take that minimum length into consideration before seeing if it is ready to sent to the remote host.

codecov[bot] commented 2 years ago

Codecov Report

Merging #151 (c8fb528) into master (15fc619) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          17       17           
  Lines        3476     3476           
=======================================
  Hits         3475     3475           
  Misses          1        1           
Flag Coverage Δ
py3.10 99.94% <100.00%> (ø)
py3.6 99.94% <100.00%> (ø)
py3.7 99.94% <100.00%> (ø)
py3.8 99.94% <100.00%> (ø)
py3.9 99.94% <100.00%> (ø)
ubuntu 73.47% <100.00%> (ø)
windows 99.53% <100.00%> (ø)
x64 99.97% <100.00%> (ø)
x86 99.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/psrp/_connection/connection.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15fc619...c8fb528. Read the comment docs.