search

jborean93 / pyspnego

Python SPNEGO authentication library
MIT License
52 stars 11 forks source link

Retrieve forwardable kerb tkt in thread safe way #14

Closed jborean93 closed 3 years ago

jborean93 commented 3 years ago

This changes how a forwardable Kerberos ticket is retrieved by using the Kerberos API directly instead of using GSSAPI. The original method relied on environment variables which are not thread safe. By using the Kerberos API this can retrieve the credentials in any way desired and store them in a thread safe context.

codecov[bot] commented 3 years ago

Codecov Report

Merging #14 (0bf8a59) into main (4f6f2fb) will decrease coverage by 0.04%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   99.62%   99.58%   -0.05%     
==========================================
  Files          25       25              
  Lines        4298     4301       +3     
==========================================
+ Hits         4282     4283       +1     
- Misses         16       18       +2
Impacted Files Coverage Δ
spnego/gss.py 98.03% <93.33%> (-0.80%) :arrow_down:
spnego/auth.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f6f2fb...0bf8a59. Read the comment docs.

jborean93 commented 3 years ago

Cannot do much about the 2 lines not in coverage as CI doesn't test out Heimdal. I've verified the changes based on the integration tests though.