search

jborean93 / pyspnego

Python SPNEGO authentication library
MIT License
52 stars 11 forks source link

Fix retrieving negotiate attributes at the start #35

Closed jborean93 closed 2 years ago

jborean93 commented 2 years ago

Ensure an empty context list will not cause an exception when attempting to retrieve attributes like client_principal, negotiate_protocol and so on. This can occur when the client proxy has been created but before any stepping has been done.

Fixes https://github.com/jborean93/pyspnego/issues/33

codecov[bot] commented 2 years ago

Codecov Report

Merging #35 (d0cc9c0) into main (079b90a) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          29       29           
  Lines        4225     4225           
=======================================
  Hits         4224     4224           
  Misses          1        1
Flag Coverage Δ
macOS 94.01% <50.00%> (ø)
py3.10 99.95% <100.00%> (ø)
py3.6 99.97% <100.00%> (ø)
py3.7 99.95% <100.00%> (ø)
py3.8 99.95% <100.00%> (ø)
py3.9 99.95% <100.00%> (ø)
ubuntu 96.51% <100.00%> (ø)
windows 94.17% <50.00%> (ø)
x64 99.97% <100.00%> (ø)
x86 94.15% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/spnego/_negotiate.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 079b90a...d0cc9c0. Read the comment docs.

jborean93 commented 2 years ago

Fantastic, thanks for confirming, will hopefully have a new release sometime shortly.