Closed mgorny closed 2 years ago
Merging #49 (224396e) into main (66665d4) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 30 30
Lines 4342 4342
=======================================
Hits 4340 4340
Misses 2 2
Flag | Coverage Δ | |
---|---|---|
macOS | 93.32% <ø> (ø) |
|
py3.10 | 99.95% <ø> (ø) |
|
py3.11-dev | 99.95% <ø> (ø) |
|
py3.7 | 99.95% <ø> (ø) |
|
py3.8 | 99.95% <ø> (ø) |
|
py3.9 | 99.95% <ø> (ø) |
|
ubuntu | 95.82% <ø> (ø) |
|
windows | 94.26% <ø> (ø) |
|
x64 | 99.95% <ø> (ø) |
|
x86 | 94.24% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
One question I forgot to ask, does your build process have passing tests with these changes?
One question I forgot to ask, does your build process have passing tests with these changes?
Yep, all tests pass for me.
Weird, I remember this was definitely needed but maybe how I was running the tests at the time has changed. Glad it's no longer needed and I can remove the code.
Thanks! Feel free to ping me if any new issues arise due to that.
Call
locale.setlocale()
only if the current locale is not UTF-8 already, in order to resolve errors when the system used to run tests is using a UTF-8 locale but does not have the en_US.UTF-8 locale installed as reported in https://bugs.gentoo.org/865205.While at it, fix the logic to ensure that:
is called prior to the locale manipulation, in order to actually respect the system locale. See https://docs.python.org/3/library/locale.html