jborean93 / pyspnego

Python SPNEGO authentication library
MIT License
52 stars 11 forks source link

Set NTLM Negotiate Version field #65

Closed jborean93 closed 1 year ago

jborean93 commented 1 year ago

Always set the NTLM Negotiate version flag and field when generating the message. This aligns the client behaviour to match with SSPI which also sets this value. It should improve compatibility with some NTLM servers which expect the version flag to be set in subsequent token exchanges.

Fixes: https://github.com/jborean93/smbprotocol/issues/216

codecov[bot] commented 1 year ago

Codecov Report

Merging #65 (911445c) into main (c3db058) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          31       31           
  Lines        5387     5387           
=======================================
  Hits         5385     5385           
  Misses          2        2           
Flag Coverage Δ
99.96% <100.00%> (ø)
py3.10 99.96% <100.00%> (ø)
py3.11 99.96% <100.00%> (ø)
py3.7 99.96% <100.00%> (ø)
py3.8 99.96% <100.00%> (ø)
py3.9 99.96% <100.00%> (ø)
x64 99.96% <100.00%> (ø)
x86 95.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/spnego/_ntlm.py 100.00% <100.00%> (ø)
src/spnego/_version.py 100.00% <100.00%> (ø)