jborean93 / pyspnego

Python SPNEGO authentication library
MIT License
52 stars 11 forks source link

Add support for Cython 3 for Windows extensions #66

Closed jborean93 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #66 (f2a8ad8) into main (3c1d1a8) will decrease coverage by 3.81%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   99.96%   96.15%   -3.81%     
==========================================
  Files          31       31              
  Lines        5387     5387              
==========================================
- Hits         5385     5180     -205     
- Misses          2      207     +205     
Flag Coverage Δ
96.15% <100.00%> (-3.81%) :arrow_down:
py3.10 96.15% <100.00%> (-3.81%) :arrow_down:
py3.11 96.15% <100.00%> (-3.81%) :arrow_down:
py3.7 96.15% <100.00%> (-3.81%) :arrow_down:
py3.8 96.15% <100.00%> (-3.81%) :arrow_down:
py3.9 96.15% <100.00%> (-3.81%) :arrow_down:
x64 96.15% <100.00%> (-3.81%) :arrow_down:
x86 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/spnego/_version.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

jborean93 commented 1 year ago

Looks like while the extensions are compiling they are causing a segfault when being used. The first test that encounters this is `tests/test_auth.py::test_negotiate_through_python_ntlm.

Maybe it's related to the warning when sspi.c is compiled

src\spnego_sspi_raw\sspi.c(1488): warning C4005: '__pyx_nonatomic_int_type': macro redefinition src\spnego_sspi_raw\sspi.c(1439): note: see previous definition of '__pyx_nonatomic_int_type'

Will need to investigate further before this change can be merged.

jborean93 commented 1 year ago

Closing in favour of https://github.com/jborean93/pyspnego/pull/69. That PR moves the SSPI code out into an external dependency which is already Cython 3 compatible.