jborean93 / pyspnego

Python SPNEGO authentication library
MIT License
52 stars 11 forks source link

Migrate SSPI to external library #69

Closed jborean93 closed 11 months ago

jborean93 commented 11 months ago

This commit adds a new dependency for Windows that includes the sspi bindings. This removes the extra Cython build step for Windows allowing it to be shipped as a pure wheel and simplifying our build steps. It also solves the problem with Cython 3 that our original Cython code was incompatible with. Finally it removes extra code allowing it to be tested in a more self contained library.

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (2794c49) 99.96% compared to head (e7d13bf) 99.96%.

:exclamation: Current head e7d13bf differs from pull request most recent head 6fc56e0. Consider uploading reports for the commit 6fc56e0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #69 +/- ## ========================================== - Coverage 99.96% 99.96% -0.01% ========================================== Files 31 30 -1 Lines 5387 5357 -30 ========================================== - Hits 5385 5355 -30 Misses 2 2 ``` | [Flag](https://app.codecov.io/gh/jborean93/pyspnego/pull/69/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/jborean93/pyspnego/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.96% <100.00%> (-0.01%)` | :arrow_down: | | [py3.10](https://app.codecov.io/gh/jborean93/pyspnego/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.92% <100.00%> (-0.01%)` | :arrow_down: | | [py3.11](https://app.codecov.io/gh/jborean93/pyspnego/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.92% <100.00%> (-0.01%)` | :arrow_down: | | [py3.12.0-rc.1](https://app.codecov.io/gh/jborean93/pyspnego/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.92% <100.00%> (-0.01%)` | :arrow_down: | | [py3.7](https://app.codecov.io/gh/jborean93/pyspnego/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `?` | | | [py3.8](https://app.codecov.io/gh/jborean93/pyspnego/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.92% <100.00%> (-0.01%)` | :arrow_down: | | [py3.9](https://app.codecov.io/gh/jborean93/pyspnego/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.96% <100.00%> (-0.01%)` | :arrow_down: | | [x64](https://app.codecov.io/gh/jborean93/pyspnego/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.96% <100.00%> (-0.01%)` | :arrow_down: | | [x86](https://app.codecov.io/gh/jborean93/pyspnego/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `95.83% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/jborean93/pyspnego/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | Coverage Δ | | |---|---|---| | [src/spnego/\_sspi.py](https://app.codecov.io/gh/jborean93/pyspnego/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean#diff-c3JjL3NwbmVnby9fc3NwaS5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.