Closed hamarituc closed 1 month ago
Thanks for the PR, I probably would prefer to keep the older import as a fallback in case someone still running with an older cryptography version.
I’ll probably need to also figure out another way forward for the future as it looks like it’ll be removed from cryptography as well in a future release but for now let’s get it working.
Edit: I misread the changelog, it’ll still be there, the old import will be removed in the future.
Attention: Patch coverage is 66.66667%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 99.92%. Comparing base (
2811a7e
) to head (e51fa02
).
Files | Patch % | Lines |
---|---|---|
src/spnego/_ntlm_raw/crypto.py | 60.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for fixing this up, I pushed a small commit that cleaned up some metadata and added the old import back in as a fallback.
Starting with cryptography-44.0.0 the ARC4 cipher was relocated to a module for deprecated ciphers. It needs to be imported from there now.