jborean93 / requests-credssp

An authentication handler for using CredSSP with Python Requests.
MIT License
21 stars 3 forks source link

Fix Spnego stop iterator error #16

Closed jborean93 closed 4 years ago

jborean93 commented 4 years ago

Turns out when you are using the auto auth (SPNEGO), have both gsspi and gss-ntlmssp installed, and ultimately authenticate with NTLM auth in SPNEGO it will fail with a StopIteration error. This is because we call step() one more time after receiving the MIC on the final response and when after sending the final token we didn't yield anything back ending the generator.

Technically the value is None but we weren't expecting anything at this point in time.

Also ups CI to test against 3.8 and other fixes.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.08%) to 55.123% when pulling fe73e3e577ee5f8e82d08938751af5c831611024 on spnego-stop-iterator into 5dd03d8531c655085868bd12a877c8a70ae15764 on master.