jborean93 / requests-credssp

An authentication handler for using CredSSP with Python Requests.
MIT License
21 stars 3 forks source link

Use pyspnego for authentication #17

Closed jborean93 closed 4 years ago

jborean93 commented 4 years ago

Swap over to using the pyspnego library and remove all the auth bits from here. This change should have no impact on the end user but further manual testing is required.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+8.3%) to 63.548% when pulling 94470378b187000e4242be42bdb5f0e3d9282a00 on auth into 286d85bdae4b8a705be47715d3ecddfc9a93905d on master.

codecov[bot] commented 4 years ago

Codecov Report

Merging #17 into master will increase coverage by 18.38%. The diff coverage is 93.18%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #17       +/-   ##
===========================================
+ Coverage   79.09%   97.47%   +18.38%     
===========================================
  Files           4        3        -1     
  Lines         550      317      -233     
===========================================
- Hits          435      309      -126     
+ Misses        115        8      -107     
Impacted Files Coverage Δ
requests_credssp/credssp.py 96.89% <93.18%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c76bc4d...13f92f2. Read the comment docs.