search

jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
320 stars 74 forks source link

Test copy from local #106

Closed dHannasch closed 3 years ago

dHannasch commented 3 years ago

This is built atop https://github.com/jborean93/smbprotocol/pull/105; look there first.

jborean93 commented 3 years ago

This is really a personal preference but for future PRs and requests would you be able to submit them as a single PR, or at least just do them 1 PR at a time. It's a bit hard to keep track of what PR does what and what has currently been merged and what has not when PRs contain changes in other PRs. It also helps to illustrate the bigger picture of what you are trying to achieve. If you do prefer to submit them in smaller increments then let's mark them as a draft PR when you open it until the required code already in flight has been merged in. That lets me know what reviews to focus on first.

Thanks for contributing these changes though, they are greatly appreciated. I'm just trying to make this easier for both of us going forward.

codecov[bot] commented 3 years ago

Codecov Report

Merging #106 (edb12f4) into master (a08ea1a) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files          23       23           
  Lines        4966     4966           
=======================================
  Hits         4911     4911           
  Misses         55       55

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a08ea1a...edb12f4. Read the comment docs.