search

jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
318 stars 73 forks source link

Ignore ENOTCONN socket errors #110

Closed Alex-Weatherhead closed 3 years ago

Alex-Weatherhead commented 3 years ago

Address the (presumably) Linux-specific race condition in socket.shutdown()

See https://github.com/FreeOpcUa/python-opcua/issues/739 for a similar issue/fix

codecov[bot] commented 3 years ago

Codecov Report

Merging #110 (b1128ba) into master (3c58580) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          23       23           
  Lines        4979     4980    +1     
=======================================
+ Hits         4910     4911    +1     
  Misses         69       69
Impacted Files Coverage Δ
smbprotocol/transport.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c58580...b1128ba. Read the comment docs.

trevoryao commented 3 years ago

Have also experienced this bug before, simple fix that would get rid of a lot of dirty work arounds