search

jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
320 stars 74 forks source link

Few improvements #113

Closed stastnypremysl closed 3 years ago

stastnypremysl commented 3 years ago

Hello.

I have made few small improvements to your project.

Would it be possible to bump up a version, if you like my changes, so I can download it directly from PyPi?

Thanks P.

codecov[bot] commented 3 years ago

Codecov Report

Merging #113 (605e489) into master (d6d21a0) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          24       24           
  Lines        4993     4993           
=======================================
  Hits         4924     4924           
  Misses         69       69
Impacted Files Coverage Δ
smbclient/_pool.py 91.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6d21a0...605e489. Read the comment docs.

jborean93 commented 3 years ago

Thanks for the PR. I had to make a slight tweak as is_dir isn't a function in _os.py. Instead you should be using os.path.isdir which returns whether the path is a bool or not.