search

jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
318 stars 73 forks source link

Migrate to GHA #145

Closed jborean93 closed 2 years ago

jborean93 commented 2 years ago

Azure Pipelines is too slow to add new Python versions and I'm in the progress of updating my various libraries to GitHub Actions instead.

codecov[bot] commented 2 years ago

Codecov Report

Merging #145 (92624c1) into master (16299b4) will increase coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files          23       23           
  Lines        4992     4993    +1     
=======================================
+ Hits         4938     4939    +1     
  Misses         54       54
Flag Coverage Δ
macOS 67.49% <ø> (?)
py3.10 98.89% <ø> (?)
py3.6 98.89% <ø> (?)
py3.7 98.89% <ø> (?)
py3.8 98.89% <ø> (?)
py3.9 98.91% <ø> (?)
ubuntu 96.50% <ø> (?)
windows 98.83% <ø> (?)
x64 98.91% <ø> (?)
x86 98.83% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
smbprotocol/file_info.py 100.00% <ø> (ø)
smbprotocol/dfs.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16299b4...92624c1. Read the comment docs.

jborean93 commented 2 years ago

@adiroiban I should have listened to you in the first place :)

adiroiban commented 2 years ago

Thanks for the update. Happy to see the GHA migration.

Not sure why Azure Devops images are slow...I was expecting GitHub and Azure to share the same images... but maybe Azure is more "enterprise" so it plays safe.

I am using both Azure and GitHub for automated tests. I think that GItHub is where the cool kids are hanging out. There are a lot of nice helpers for github acions.

ex https://mxschmitt.github.io/action-tmate/ is awesome for debugging strange tests that pass on your system but fail on CI.

I expect that at some point MS will close Azure Devops and we will only have GitHub...but maybe in 5 years as GitHub still has to catch up on test analytics functionality... and I hope retry failed-jobs will be available on GitHub soon.

jborean93 commented 2 years ago

Not sure why Azure Devops images are slow

I meant slow to update versions. For example GHA had Python 3.10 support essentially when it came out whereas Azure Pipelines had to wait for it to trickle in. I believe they also dropped Python x86 on Windows which isn't the end of the world for this library but on others where I build Windows wheels can be important to test.