jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
318 stars 73 forks source link

Make referral expiry check private and add changelog #146

Closed jborean93 closed 2 years ago

jborean93 commented 2 years ago

Tiny refinement of https://github.com/jborean93/smbprotocol/pull/144.

Will have to eventually look at the expiry checks for the domain/dc referral expiry but that is less important compared to path referrals.

codecov[bot] commented 2 years ago

Codecov Report

Merging #146 (58ecee6) into master (16299b4) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files          23       23           
  Lines        4992     4994    +2     
=======================================
+ Hits         4938     4940    +2     
  Misses         54       54           
Flag Coverage Δ
macOS 67.50% <60.00%> (?)
py3.10 98.89% <100.00%> (?)
py3.6 98.89% <100.00%> (?)
py3.7 98.89% <100.00%> (?)
py3.8 98.89% <100.00%> (?)
py3.9 98.91% <100.00%> (?)
ubuntu 96.51% <100.00%> (?)
windows 98.83% <100.00%> (?)
x64 98.91% <100.00%> (?)
x86 98.83% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
smbprotocol/file_info.py 100.00% <ø> (ø)
smbclient/_pool.py 91.57% <100.00%> (+0.04%) :arrow_up:
smbprotocol/dfs.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1e6432...58ecee6. Read the comment docs.