jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
318 stars 73 forks source link

InfoAdditionalInformation should be of type flags and not enum fixes #152 #153

Closed wokis closed 2 years ago

wokis commented 2 years ago

…#152

codecov[bot] commented 2 years ago

Codecov Report

Merging #153 (3f130e6) into master (2b3403b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files          23       23           
  Lines        5063     5063           
=======================================
  Hits         5017     5017           
  Misses         46       46           
Flag Coverage Δ
macOS 68.22% <ø> (ø)
py3.10 99.07% <ø> (ø)
py3.6 99.07% <ø> (ø)
py3.7 99.07% <ø> (ø)
py3.8 99.07% <ø> (ø)
py3.9 99.09% <ø> (ø)
ubuntu 96.77% <ø> (ø)
windows 99.00% <ø> (ø)
x64 99.09% <ø> (ø)
x86 99.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
smbprotocol/open.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b3403b...3f130e6. Read the comment docs.

jborean93 commented 2 years ago

Thanks for the PR, just added a changelog entry but the changes look good.