search

jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
318 stars 73 forks source link

Fix incorrect name mangling #162

Closed linuskr closed 2 years ago

linuskr commented 2 years ago

Since self.__kwargs is set in SMBRawIO.__init__, its name will always be _SMBRawIO__kwargs. This fixes connection_cache not being passed to get_smb_tree in dfs referrals

codecov[bot] commented 2 years ago

Codecov Report

Merging #162 (22d8978) into master (034bd88) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files          23       23           
  Lines        5063     5063           
=======================================
  Hits         5017     5017           
  Misses         46       46
Flag Coverage Δ
macOS 68.22% <0.00%> (ø)
py3.10 99.07% <100.00%> (ø)
py3.6 99.07% <100.00%> (ø)
py3.7 99.07% <100.00%> (ø)
py3.8 99.07% <100.00%> (ø)
py3.9 99.09% <100.00%> (ø)
ubuntu 96.77% <100.00%> (ø)
windows 99.00% <100.00%> (ø)
x64 99.09% <100.00%> (ø)
x86 99.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
smbclient/_io.py 99.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 034bd88...22d8978. Read the comment docs.

jborean93 commented 2 years ago

Thanks for the pickup on this.