jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
316 stars 73 forks source link

Fix rename operations for a DFS path #191

Closed jborean93 closed 2 years ago

jborean93 commented 2 years ago

Turns out the path is resolved correctly and I can use the DFS path to be normalized but I need to ensure

Fixes: https://github.com/jborean93/smbprotocol/issues/170#issuecomment-1221858156

codecov[bot] commented 2 years ago

Codecov Report

Merging #191 (2415aa4) into master (08b7dcf) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files          24       24           
  Lines        5076     5079    +3     
=======================================
+ Hits         5030     5033    +3     
  Misses         46       46           
Flag Coverage Δ
macOS 68.18% <33.33%> (-0.03%) :arrow_down:
py3.10 99.07% <100.00%> (+<0.01%) :arrow_up:
py3.7 99.07% <100.00%> (+<0.01%) :arrow_up:
py3.8 99.07% <100.00%> (+<0.01%) :arrow_up:
py3.9 99.09% <100.00%> (+<0.01%) :arrow_up:
ubuntu 96.78% <100.00%> (+<0.01%) :arrow_up:
windows 99.01% <100.00%> (+<0.01%) :arrow_up:
x64 99.09% <100.00%> (+<0.01%) :arrow_up:
x86 99.01% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/smbclient/_io.py 99.02% <ø> (-0.01%) :arrow_down:
src/smbclient/_os.py 98.49% <100.00%> (+0.01%) :arrow_up:
src/smbclient/_pool.py 95.93% <100.00%> (+0.04%) :arrow_up:
src/smbprotocol/connection.py 99.84% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.