search

jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
323 stars 73 forks source link

adding support for remote to local operations in shutil.py::copytree #226

Closed brno32 closed 1 year ago

brno32 commented 1 year ago

Step 1 to address https://github.com/jborean93/smbprotocol/issues/221

Splitting this into two PRs.

I had trouble getting the tests to work locally (even the unit tests that don't need an actual samba share to talk to), but tested manually. I am expecting the test I added to pass in CI

codecov[bot] commented 1 year ago

Codecov Report

Merging #226 (66f5609) into master (8008656) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage   99.07%   99.09%   +0.01%     
==========================================
  Files          24       24              
  Lines        5082     5083       +1     
==========================================
+ Hits         5035     5037       +2     
+ Misses         47       46       -1
Flag Coverage Δ
99.09% <100.00%> (+0.01%) :arrow_up:
py3.10 99.05% <100.00%> (+0.01%) :arrow_up:
py3.11 99.05% <100.00%> (+0.09%) :arrow_up:
py3.7 99.05% <100.00%> (+0.01%) :arrow_up:
py3.8 99.05% <100.00%> (+0.01%) :arrow_up:
py3.9 99.09% <100.00%> (+0.10%) :arrow_up:
x64 99.09% <100.00%> (+0.01%) :arrow_up:
x86 99.01% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/smbclient/shutil.py 95.71% <100.00%> (+0.52%) :arrow_up:

... and 5 files with indirect coverage changes

jborean93 commented 1 year ago

Thanks for working on this.