Closed brno32 closed 1 year ago
Merging #227 (224339e) into master (285ad28) will decrease coverage by
0.02%
. The diff coverage is80.00%
.
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 99.09% 99.07% -0.02%
==========================================
Files 24 24
Lines 5081 5085 +4
==========================================
+ Hits 5035 5038 +3
- Misses 46 47 +1
Flag | Coverage Δ | |
---|---|---|
99.07% <80.00%> (-0.02%) |
:arrow_down: | |
py3.10 | 99.03% <80.00%> (-0.02%) |
:arrow_down: |
py3.11 | 99.03% <80.00%> (-0.02%) |
:arrow_down: |
py3.7 | 99.02% <80.00%> (-0.02%) |
:arrow_down: |
py3.8 | 99.03% <80.00%> (-0.02%) |
:arrow_down: |
py3.9 | 99.07% <80.00%> (-0.02%) |
:arrow_down: |
x64 | 99.07% <80.00%> (-0.02%) |
:arrow_down: |
x86 | 98.99% <80.00%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/smbclient/shutil.py | 95.32% <80.00%> (-0.39%) |
:arrow_down: |
@jborean93 are you okay with this kind of approach?
Hey sorry I haven't had a chance to look at this yet, I've got a few things on my plate right now.
Good suggestions! I can work on tackling symlinks next if this looks like a good starting point
Sorry it took so long to review this.
pt. 2 of addressing https://github.com/jborean93/smbprotocol/issues/221
Tackling symlinks looks a little daunting, so I'd like to circle back after making sure my current approach is aligned with the project.
It crossed my mind to have both
LocalDirEntry
andSMBDirEntry
inherit from the same abstract class, but I've opted to keep it simple