jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
316 stars 73 forks source link

support for resolved symlinks in copytree #230

Open brno32 opened 1 year ago

brno32 commented 1 year ago

Fixes https://github.com/jborean93/smbprotocol/issues/221

codecov[bot] commented 1 year ago

Codecov Report

Merging #230 (1cadb72) into master (b81d5f1) will decrease coverage by 0.08%. The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
- Coverage   99.07%   98.99%   -0.08%     
==========================================
  Files          24       24              
  Lines        5085     5095      +10     
==========================================
+ Hits         5038     5044       +6     
- Misses         47       51       +4     
Flag Coverage Δ
98.99% <92.85%> (-0.08%) :arrow_down:
py3.10 98.95% <92.85%> (-0.08%) :arrow_down:
py3.11 ?
py3.7 98.94% <92.85%> (-0.08%) :arrow_down:
py3.8 ?
py3.9 98.97% <92.85%> (-0.10%) :arrow_down:
x64 98.95% <92.85%> (-0.12%) :arrow_down:
x86 98.99% <92.85%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/smbclient/shutil.py 95.53% <92.85%> (+0.20%) :arrow_up:

... and 2 files with indirect coverage changes

jborean93 commented 1 year ago

Just an FYI the Samba target doesn't support symlinks so you'll need to only run the symlink tests on Windows.

Neustradamus commented 2 weeks ago

@brno32, @jborean93: Any progress on it?