jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
320 stars 73 forks source link

Combine coverage before upload #236

Closed dolfinus closed 1 year ago

dolfinus commented 1 year ago

While working on #234 I've found that each matrix jobs sends coverage to Codecov. Different environment have different number of tests running (for example, on MacOS integration tests are skipped), and this leads to reporting wrong coverage information until all matrix jobs are finished.

Here I've separated running tests & saving the coverage info and combining & sending coverage report to CodeCov. This is done by switching from pytest-cov to coverage package.

Also updated run-ci.sh script, allowing to explicitly pass names of steps which should be run. This allows retry failed steps, or force stop SMB server container if tests are failed. Default behavior remains the same, all steps are run.

codecov[bot] commented 1 year ago

Codecov Report

Merging #236 (fb3a960) into master (f3fbe4f) will decrease coverage by 0.75%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   99.07%   98.32%   -0.75%     
==========================================
  Files          24       24              
  Lines        5078     5078              
  Branches        0      658     +658     
==========================================
- Hits         5031     4993      -38     
  Misses         47       47              
- Partials        0       38      +38     
Flag Coverage Δ
?
py3.10 ?
py3.11 ?
py3.7 ?
py3.8 ?
py3.9 ?
x64 ?
x86 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes