jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
320 stars 73 forks source link

Fix DFS recurision for missing files #239

Closed jborean93 closed 1 year ago

jborean93 commented 1 year ago

The code that handles a missing path does not currently record existing DFS target servers that have been tried resulting in a recursion error. By ensuring a DFS target is only retried if it hasn't already it should avoid this recursion problem.

Fixes: https://github.com/jborean93/smbprotocol/issues/228

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.02% :warning:

Comparison is base (72eed28) 99.07% compared to head (3df1958) 99.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #239 +/- ## ========================================== - Coverage 99.07% 99.05% -0.02% ========================================== Files 24 24 Lines 5088 5093 +5 ========================================== + Hits 5041 5045 +4 - Misses 47 48 +1 ``` | [Flag](https://app.codecov.io/gh/jborean93/smbprotocol/pull/239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/jborean93/smbprotocol/pull/239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.05% <80.00%> (-0.02%)` | :arrow_down: | | [py3.10](https://app.codecov.io/gh/jborean93/smbprotocol/pull/239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.01% <80.00%> (-0.02%)` | :arrow_down: | | [py3.11](https://app.codecov.io/gh/jborean93/smbprotocol/pull/239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.01% <80.00%> (-0.02%)` | :arrow_down: | | [py3.12.0-rc.1](https://app.codecov.io/gh/jborean93/smbprotocol/pull/239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.01% <80.00%> (-0.02%)` | :arrow_down: | | [py3.7](https://app.codecov.io/gh/jborean93/smbprotocol/pull/239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.00% <80.00%> (-0.02%)` | :arrow_down: | | [py3.8](https://app.codecov.io/gh/jborean93/smbprotocol/pull/239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.01% <80.00%> (-0.02%)` | :arrow_down: | | [py3.9](https://app.codecov.io/gh/jborean93/smbprotocol/pull/239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.05% <80.00%> (-0.02%)` | :arrow_down: | | [x64](https://app.codecov.io/gh/jborean93/smbprotocol/pull/239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.05% <80.00%> (-0.02%)` | :arrow_down: | | [x86](https://app.codecov.io/gh/jborean93/smbprotocol/pull/239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `98.97% <80.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/jborean93/smbprotocol/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | Coverage Δ | | |---|---|---| | [src/smbclient/\_io.py](https://app.codecov.io/gh/jborean93/smbprotocol/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean#diff-c3JjL3NtYmNsaWVudC9faW8ucHk=) | `98.73% <80.00%> (-0.31%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.