jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
320 stars 73 forks source link

Add 0xc000007f to mapping #245

Closed rsdoherty closed 11 months ago

rsdoherty commented 11 months ago

Adds the low disk space code to the mapping, so a more descriptive error is raised.

From https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-cifs/8f11e0f3-d545-46cc-97e6-f00569e3e1bc:

image

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (942b005) 99.05% compared to head (35f6b8f) 99.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #245 +/- ## ======================================= Coverage 99.05% 99.05% ======================================= Files 24 24 Lines 5093 5097 +4 ======================================= + Hits 5045 5049 +4 Misses 48 48 ``` | [Flag](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.05% <100.00%> (+<0.01%)` | :arrow_up: | | [py3.10](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.01% <100.00%> (+<0.01%)` | :arrow_up: | | [py3.11](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.01% <100.00%> (+<0.01%)` | :arrow_up: | | [py3.12.0-rc.1](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.01% <100.00%> (+<0.01%)` | :arrow_up: | | [py3.7](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.00% <100.00%> (+<0.01%)` | :arrow_up: | | [py3.8](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.01% <100.00%> (+<0.01%)` | :arrow_up: | | [py3.9](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.05% <100.00%> (+<0.01%)` | :arrow_up: | | [x64](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.05% <100.00%> (+<0.01%)` | :arrow_up: | | [x86](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `98.97% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | Coverage Δ | | |---|---|---| | [src/smbprotocol/exceptions.py](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean#diff-c3JjL3NtYnByb3RvY29sL2V4Y2VwdGlvbnMucHk=) | `100.00% <100.00%> (ø)` | | | [src/smbprotocol/header.py](https://app.codecov.io/gh/jborean93/smbprotocol/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean#diff-c3JjL3NtYnByb3RvY29sL2hlYWRlci5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rsdoherty commented 11 months ago

Makes sense - thanks!

jborean93 commented 11 months ago

Thanks for adding this and appreciate you taking the time to make the changes after my review!

rsdoherty commented 11 months ago

No problem! I'm actually contributing this as I'm using pypsexec for some automation, so I'd be keen to get this into a release that's on pypi so I can bump the dependency in my application if possible, please?

rsdoherty commented 11 months ago

Hey @jborean93 - are you able to review the above please?

jborean93 commented 11 months ago

Sorry I will look at pushing a new release tomorrow.

jborean93 commented 11 months ago

v1.12.0 has been pushed to PyPI with these changes https://pypi.org/project/smbprotocol/.

rsdoherty commented 11 months ago

Thanks!