Closed jborean93 closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
eaf24fa
) 99.05% compared to head (1d3c6b5
) 99.06%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you so much!
I was hoping you'd be fine with using the data and wanted to ask to create a PR for that, but you have been blazing fast!
I tested your PR code, it is working smoothly! And even faster on large files than ls -Al
on a cifs mount 🔥 (~4:30min against ~10min for 280k files).
I was hoping you'd be fine with using the data and wanted to ask to create a PR for that, but you have been blazing fast!
You just picked the right time to open the issue, I've been neglecting this library for a while now and needed to get back to it.
I tested your PR code, it is working smoothly! And even faster on large files than ls -Al on a cifs mount 🔥 (~4:30min against ~10min for 280k files).
Thanks for testing, I'm actually surprised it's faster than a cifs mount but always happen to see that there are some benefits here :)
Adds the property smb_info to the scandir enumerated result which contains the already retrieved metadata on the file during the scan operation. This provides a more efficient way for callers to retrieve information like the file times, sizes, attributes straight away without having to call .stat() which results in another SMB request to the server.
Fixes: https://github.com/jborean93/smbprotocol/issues/250