codecov[bot]
commented
9 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
4e69397) 99.06% compared to head (8a66b3f) 99.04%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #266 +/- ## ========================================== - Coverage 99.06% 99.04% -0.02% ========================================== Files 24 24 Lines 5115 5113 -2 ========================================== - Hits 5067 5064 -3 - Misses 48 49 +1 ``` | [Flag](https://app.codecov.io/gh/jborean93/smbprotocol/pull/266/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/jborean93/smbprotocol/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.04% <ø> (-0.02%)` | :arrow_down: | | [py3.10](https://app.codecov.io/gh/jborean93/smbprotocol/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.00% <ø> (-0.02%)` | :arrow_down: | | [py3.11](https://app.codecov.io/gh/jborean93/smbprotocol/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.00% <ø> (-0.02%)` | :arrow_down: | | [py3.12](https://app.codecov.io/gh/jborean93/smbprotocol/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.00% <ø> (-0.02%)` | :arrow_down: | | [py3.7](https://app.codecov.io/gh/jborean93/smbprotocol/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `98.99% <ø> (-0.03%)` | :arrow_down: | | [py3.8](https://app.codecov.io/gh/jborean93/smbprotocol/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.00% <ø> (-0.02%)` | :arrow_down: | | [py3.9](https://app.codecov.io/gh/jborean93/smbprotocol/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.04% <ø> (-0.02%)` | :arrow_down: | | [x64](https://app.codecov.io/gh/jborean93/smbprotocol/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `99.04% <ø> (-0.02%)` | :arrow_down: | | [x86](https://app.codecov.io/gh/jborean93/smbprotocol/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean) | `98.96% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Borean#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Change to not set the SessionId and TreeId in the SMB headers of related compound requests as it is not in the spec. The spec only states the FileId used in the first create should be set to all bits and not these other two fields.
Fixes: https://github.com/jborean93/smbprotocol/issues/260