search

jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
318 stars 73 forks source link

Drop Python 2 support. #95

Closed dHannasch closed 3 years ago

dHannasch commented 3 years ago

This would remote support for Python 2 from smbprotocol (see https://github.com/jborean93/smbprotocol/issues/94).

codecov[bot] commented 3 years ago

Codecov Report

Merging #95 (111dac2) into master (9a141ec) will decrease coverage by 0.28%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   98.84%   98.56%   -0.29%     
==========================================
  Files          23       23              
  Lines        4948     4948              
==========================================
- Hits         4891     4877      -14     
- Misses         57       71      +14
Impacted Files Coverage Δ
smbprotocol/_compat.py 50.00% <0.00%> (-50.00%) :arrow_down:
smbclient/shutil.py 91.70% <0.00%> (-2.77%) :arrow_down:
smbprotocol/transport.py 97.82% <0.00%> (-1.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a141ec...111dac2. Read the comment docs.

jborean93 commented 3 years ago

This has been done with https://github.com/jborean93/smbprotocol/pull/104 which also dropped Python 3.5 as that is end of life.