search

jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
318 stars 73 forks source link

Single basename function for remote and local paths. #98

Closed dHannasch closed 3 years ago

dHannasch commented 3 years ago

This is built atop https://github.com/jborean93/smbprotocol/pull/103; see that first.

Codecov is complaining about smbclient/shutil.py#L445, not sure what's up with that, that was just replacing a basename call, none of the logic leading to that line should have changed. In any case, that line will be removed by https://github.com/jborean93/smbprotocol/pull/96.

codecov[bot] commented 3 years ago

Codecov Report

Merging #98 (3409f70) into master (af569b5) will decrease coverage by 0.29%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   98.84%   98.55%   -0.30%     
==========================================
  Files          23       23              
  Lines        4950     4991      +41     
==========================================
+ Hits         4893     4919      +26     
- Misses         57       72      +15
Impacted Files Coverage Δ
smbclient/shutil.py 91.85% <83.33%> (-2.62%) :arrow_down:
smbclient/_os.py 98.48% <100.00%> (+0.03%) :arrow_up:
smbprotocol/_compat.py 50.00% <0.00%> (-50.00%) :arrow_down:
smbprotocol/transport.py 96.93% <0.00%> (-1.98%) :arrow_down:
smbprotocol/structure.py 100.00% <0.00%> (ø)
smbprotocol/exceptions.py 100.00% <0.00%> (ø)
smbclient/_io.py 99.02% <0.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af569b5...3409f70. Read the comment docs.