jborg / attic

Deduplicating backup program
Other
1.11k stars 104 forks source link

acl_use_local_uid_gid has suspicious code #359

Open ThomasWaldmann opened 8 years ago

ThomasWaldmann commented 8 years ago

See there:

https://github.com/jborg/attic/blob/0.16/attic/platform_linux.pyx#L41

Note that it does not use the fields[1] value it has just computed. Also, if it did, it would fall over it being an int sometimes.