search

jborgers / PMD-jPinpoint-rules

PMD rule set for responsible Java and Kotlin coding: performance, sustainability, multi-threading, data mixup and more.
Apache License 2.0
43 stars 10 forks source link

Pmd7 upgrade 7.2.0 #317

Closed jborgers closed 4 months ago

stokpop commented 4 months ago

The PR says to merge into master, but should be based on and merged into pmd7 branch?

Ah, you can change the merge into branch via UI. Changed it to pmd7.

stokpop commented 4 months ago

Looking at this PR I found this:

Is the remark about use of DomXPathRule valid for us? https://pmd.github.io/pmd/pmd_userdocs_migrating_to_pmd7.html#xml-and-pom Did not see that class, is that 7.3.0-SNAPSHOT specific?

stokpop commented 4 months ago

note: src/test/resources/com/jpinpoint/perf/lang/java/ruleset/common/xml seems to contain all xml files

should all be deleted and only contain the migrated ones? they are also in test-todo branch

jborgers commented 4 months ago

Looking at this PR I found this:

Is the remark about use of DomXPathRule valid for us? https://pmd.github.io/pmd/pmd_userdocs_migrating_to_pmd7.html#xml-and-pom Did not see that class, is that 7.3.0-SNAPSHOT specific?

DomXPathRule seems an improvement indeed! You can access comments! To try out

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jborgers commented 4 months ago

note: src/test/resources/com/jpinpoint/perf/lang/java/ruleset/common/xml seems to contain all xml files

should all be deleted and only contain the migrated ones? they are also in test-todo branch

Yes, indeed, it worked without removal, but they should be removed, done.