Pmd7 upgrade 7.2.0 spring set 01

[stokpop]

spring set 01 remarks:

AvoidModelMapAsRenderParameter - unit tests not complete (e.g. non-matches missing, second part of xpath expression is not covered) and what is comment for two bad ones: "[--> NOT, see JPCC-88?]"

AvoidSpringApplicationContextRecreationTest - assume creation of all ApplicationContexts is bad in methods - does not work in designer without proper classpath imports

PMD7 question: Why MethodDeclaration,LocalVariableDeclaration,FieldDeclaration but VariableDeclarator?

[sonarcloud[bot]]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[jborgers]

spring set 01 remarks:

AvoidModelMapAsRenderParameter - unit tests not complete (e.g. non-matches missing, second part of xpath expression is not covered) and what is comment for two bad ones: "[--> NOT, see JPCC-88?]"

see inline

AvoidSpringApplicationContextRecreationTest - assume creation of all ApplicationContexts is bad in methods - does not work in designer without proper classpath imports

ok, if works in unit tests, fine

PMD7 question: Why MethodDeclaration,LocalVariableDeclaration,FieldDeclaration but VariableDeclarator?

Maybe historically? Going from 6 to 7 and forgot to be consistent?

[stokpop]

AvoidModelMapAsRenderParameter - unit tests not complete (e.g. non-matches missing, second part of xpath expression is not covered) and what is comment for two bad ones: "[--> NOT, see JPCC-88?]"

ok, will create issue to look at this later, let's first finish the others

PMD7 question: Why MethodDeclaration,LocalVariableDeclaration,FieldDeclaration but VariableDeclarator?

Maybe historically? Going from 6 to 7 and forgot to be consistent?

We can ask in PMD7 after migration 🙂

[stokpop]

See: https://github.com/jborgers/PMD-jPinpoint-rules/issues/373