jborgers / PMD-jPinpoint-rules

PMD rule set for responsible Java and Kotlin coding: performance, sustainability, multi-threading, data mixup and more.
Apache License 2.0
43 stars 10 forks source link

merged all tags from main (pmd6) to pmd7 #382

Closed stokpop closed 6 days ago

stokpop commented 6 days ago

common.xml

common_std.xml

ImplementEqualsHashCodeOnValueObjects - is missing? TODO?

AvoidCalendar, Sonar has a rule to use java.time instead of Calendar etc. ; this rule seems unnecessary, however, not sure, it may be useful in IntelliJ, what do you think?

I added MissingEqualsAndHashCodeWithGetterSetter, correctness, not performance nor sustainability in my view

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jborgers commented 6 days ago

ImplementEqualsHashCodeOnValueObjects - is missing? TODO?

AvoidCalendar, Sonar has a rule to use java.time instead of Calendar etc. ; this rule seems unnecessary, however, not sure, it may be useful in IntelliJ, what do you think?

I added MissingEqualsAndHashCodeWithGetterSetter, correctness, not performance nor sustainability in my view

stokpop commented 6 days ago

Seems both ImplementEqualsHashCodeOnValueObjects and AvoidUnusedAssignments are complex rules that need to be done still. Not for this PR.

stokpop commented 6 days ago

AvoidCalendar, Sonar has a rule to use java.time instead of Calendar etc. ; this rule seems unnecessary, however, not sure, it may be useful in IntelliJ, what do you think?

Then Sonar Lint plugin should be able to catch that in Intellij, right?