jboss-container-images / openjdk

Source To Image (S2I) image for Red Hat OpenShift providing OpenJDK
Apache License 2.0
54 stars 58 forks source link

[OPENJDK-2686] Jlink stage 1 - BuildConfig and Imagestream for creating a builder image with the jmods rpm installed #454

Closed Josh-Matsuoka closed 6 months ago

Josh-Matsuoka commented 7 months ago

Addresses stage 1 of the planned multi-stage jlink build

The script currently works off of a local crc instance (getting oc from crc oc-env), this can probably be generalized later if needed but for local testing it should do the trick. Requires you to be logged into the crc environment (i,e, having run oc login)

jmtd commented 7 months ago

Runtime GHA test failures are likely unrelated to this PR and due to the issue under #455.

jmtd commented 7 months ago

I think we should add a dependency on an OpenJDK imageStream, the problem is we don't provide any UBI9 ones yet. We provide

I've filed https://issues.redhat.com/browse/OPENJDK-2811 to get some added. In the meantime we should probably add a rudimentary one to this branch; I've filed https://issues.redhat.com/browse/OPENJDK-2812 for that.

jmtd commented 6 months ago

This is awesome!