jboss-container-images / openjdk

Source To Image (S2I) image for Red Hat OpenShift providing OpenJDK
Apache License 2.0
53 stars 58 forks source link

[OPENJDK-2722] Split the tests inside tests/features/java/runtime.feature to couple them with appropriate modules #465

Closed jhuttana closed 3 months ago

jhuttana commented 3 months ago

Could you please review the changes?

jmtd commented 3 months ago

The test 'Check JAVA_APP_NAME can contain spaces (OPENJDK-104)' now in modules/jvm/api/tests/features/runtime.feature should probably be in modules/run instead: all the handling of JAVA_APP_NAME is in there. Same with the tests for JAVA_APP_DIR.

Similarly, JAVA_OPTIONS is only referenced in modules/s2i/bash so that test should be there.