search

jboss-container-images / openjdk

Source To Image (S2I) image for Red Hat OpenShift providing OpenJDK
Apache License 2.0
53 stars 58 forks source link

[OPENJDK-2993] re-tag jolokia Feature #486

Closed jmtd closed 2 months ago

jmtd commented 2 months ago

Ensure the first of the three Scenarios is covered by tags.

https://issues.redhat.com/browse/OPENJDK-2993

jhuttana commented 2 months ago

I tried to run jolokia.feature with the changes in this PR and below are the results

JDK-11
$ cekit --descriptor ubi8-openjdk-11.yaml test --image ubi8/openjdk-11 behave --include-re jolokia
.
.
.
Failing scenarios:
  features/jboss.container.jolokia/jolokia.feature:6  Check Environment variable is correct

0 features passed, 1 failed, 0 skipped
2 scenarios passed, 1 failed, 0 skipped
7 steps passed, 1 failed, 0 skipped, 0 undefined
Took 10m30.844s

#######################################################################################################
JDK-8
$ cekit --descriptor ubi8-openjdk-8.yaml test --image ubi8/openjdk-8 behave --include-re jolokia
.
.
.
Failing scenarios:
  features/jboss.container.jolokia/jolokia.feature:6  Check Environment variable is correct

0 features passed, 1 failed, 0 skipped
2 scenarios passed, 1 failed, 0 skipped
7 steps passed, 1 failed, 0 skipped, 0 undefined
Took 10m29.177s

If this is a expected failure then the PR looks good to me. As per this PR https://github.com/jboss-container-images/openjdk/pull/458 it looks like the test will pass on GHA.

jmtd commented 2 months ago

@jhuttana

If this is a expected failure

Good catch: It is not, but I didn't test it after re-tagging it. I've fixed the test and pushed another commit. If you have time to verify it, that would be great!

jhuttana commented 2 months ago

@jhuttana

If this is a expected failure

Good catch: It is not, but I didn't test it after re-tagging it. I've fixed the test and pushed another commit. If you have time to verify it, that would be great!

I checked it locally and the test is passing with recent commit

$ cekit --descriptor ubi8-openjdk-8.yaml test --image ubi8/openjdk-8 behave --name 'Ensure JOLOKIA_VERSION variable aligns with JAR'
.
.
.
1 feature passed, 0 failed, 16 skipped
1 scenario passed, 0 failed, 91 skipped
2 steps passed, 0 failed, 264 skipped, 0 undefined
Took 0m11.019s
2024-04-28 13:58:12,498 cli.py:531        INFO  Finished!