search

jboss-container-images / openjdk

Source To Image (S2I) image for Red Hat OpenShift providing OpenJDK
Apache License 2.0
53 stars 58 forks source link

[Openjdk 3029] no singleton jdk - maven module edition #498

Closed jmtd closed 1 month ago

jmtd commented 1 month ago

Removing singleton-jdk from the JDK21 builder image is not sufficient, we also need to install maven-openjdk21 instead of maven-openjdk17. Thanks @sefroberg for catching this.

Test coverage: the JDK21 tests in modules/jdk/tests/features/openjdk.feature catch this (pass for this PR, fail for branch ubi8)

https://issues.redhat.com/browse/OPENJDK-3029

sefroberg commented 1 month ago

Two Questions.

  1. I noticed a Maven update to 3.8.21. Should we do this across the board for all containers?
  2. Are you going to make this change for the UBI 9 images as well?
jmtd commented 1 month ago

I noticed a Maven update to 3.8.21. Should we do this across the board for all containers?

I guess that came in with RHEL 8.10. I think/hope it should be consistent across the builds as they happened at the same time. But we should check.

Previous/current version in both the UBI8 and UBI9 images is 3.8.5