[OPENJDK-2992] Spec for deployment and route object

jboss-container-images / openjdk

Source To Image (S2I) image for Red Hat OpenShift providing OpenJDK

Apache License 2.0

53 stars 58 forks source link

[OPENJDK-2992] Spec for deployment and route object #500

Open jhuttana opened 3 weeks ago

jhuttana commented 3 weeks ago

JIRA: https://issues.redhat.com/browse/OPENJDK-2992

NOTE: My stage-2 is failing with CRI-O failed msg which is known one with our crc setup. I will have to restart or do a fresh setup to get it working fine :) Meanwhile I thought I can raise a PR so that you can take look and commented if its syntactically fine.

Could you please review the changes?

jmtd commented 3 weeks ago

I've just tried this out.

the deployment object starts to log errors as soon as the template is instantiated, and before the builds have completed.

Once the builds have completed, the route is not yet working (Application is not available)

I'm creating a deployment manually now to compare the objects in the OCP instance

jmtd commented 3 weeks ago

app one difference, the manual deployment has some kind of "Application" enclosing it

jmtd commented 3 weeks ago

I think the route object needs .spec.port.targetPort: 8080-tcp added (possibly also via a template variable)