search

jboss-developer / jboss-picketlink-quickstarts

The quickstarts demonstrate PicketLink and a few additional technologies. They provide small, specific, working examples that can be used as a reference for your own project.
96 stars 187 forks source link

fixed missing break lines and wrong link on README files #18

Closed hodrigohamalho closed 10 years ago

sgilda commented 10 years ago

@hodrigohamalho : Should the source also change?

From: Source: https://github.com/picketlink/picketlink-quickstarts/

To: Source: https://github.com/jboss-developer/jboss-picketlink-quickstarts

sgilda commented 10 years ago

@hodrigohamalho There also needs to be 2 spaces after every line of metadata, including the Author, Summary, and Source. Actually, it looks like you did that for most of them, but missed a few.

I tried running the QS Tools against these quickstarts to get the definitive list of issues, but it resulted in a number of dependency issues. It appears these quickstarts need a different Maven repository than the repositories listed here: https://github.com/sgilda/jboss-eap-quickstarts#configure-maven

rafabene commented 10 years ago

great @hodrigohamalho !!!! Nice to see you here! You can check your PR by running: mvn org.jboss.maven.plugins:maven-qstools-plugin:check

sgilda commented 10 years ago

@hodrigohamalho : How can I configure Maven to be able to build these without error?

hodrigohamalho commented 10 years ago

@sgilda you need to download https://github.com/picketlink/picketlink and build. After that the dependencies errors should be resolved.

"Actually, it looks like you did that for most of them, but missed a few." Ok, i'll fix it :)

hodrigohamalho commented 10 years ago

@rafabene, long time no see !! Thank you for the tip o/

hodrigohamalho commented 10 years ago

Is something wrong on this pr?