search

jboss-dockerfiles / hawkular-apm

Open Source Monitoring and Management Platform
http://www.hawkular.org/
MIT License
6 stars 13 forks source link

Updated to 1.0.0.Alpha11 #9

Closed garethahealy closed 8 years ago

theute commented 8 years ago

Sorry, I wasn't notified about this PR, only now thanks to @objectiser

Would have been great if you could split the PR in 2, one for aio and one for BTM as it makes it more difficult to review this way.

@objectiser will review the BTM part.

For the AIO part is there a way to not hardcode http://192.168.99.100:8080/auth ?

garethahealy commented 8 years ago

Hi,

I thought the PR was only for updating to the next alpha. Not sure why my other changes got in - they were not meant for upstream, just for my local git.

Will re-do PR.

objectiser commented 8 years ago

@garethahealy Note there is a new PR for the APM dockerfile (previously BTM), which changes the name and location. btw - just realised based on your changes that the config files for APM should really be in the config dir rather than under data, to avoid the situation you have found when trying to set the data folder to a separate location. I'll create a jira for that, for the next release.