search

jboss-dockerfiles / infinispan

Docker image for Infinispan project
19 stars 25 forks source link

docker-entrypoint doesn't detect existing -Xmx setting when applying container settings #122

Closed karlvr closed 5 years ago

karlvr commented 5 years ago

I think there's a typo in https://github.com/jboss-dockerfiles/infinispan/blob/9.4.x/server/docker-entrypoint.sh and similar on line 307 where it uses JAVA_OPTIONS to look for existing -Xmx settings.

It's the only mention of JAVA_OPTIONS in that file, or in the infinispan-server directory. I think it should be JAVA_OPTS.

gustavocoding commented 5 years ago

It is indeed a typo, but it should not affect the ability to set custom memory. The correct way is using JAVA_OPTS, example:

docker run -it  -e "JAVA_OPTS=-Xms200m -Xmx400m"  jboss/infinispan-server
gustavocoding commented 5 years ago

Fixed on master