search

jboss-dockerfiles / wildfly

Docker image for WildFly project
https://quay.io/repository/wildfly/wildfly
MIT License
279 stars 236 forks source link

Wildfly 26 with jdk 17 base image #148 #161

Closed Henri-Laiho closed 1 year ago

jwgmeligmeyling commented 1 year ago

Thanks for putting this Dockerfile out there 😄 Startup times went from 5 minutes to 13 seconds here. 🤣

jmesnil commented 1 year ago

@Henri-Laiho Thanks for this contribution.

There is a lot of value in your PR so I have opened a mail thread on wildfly-dev to discuss it with the wider WildFly community: https://lists.jboss.org/archives/list/wildfly-dev@lists.jboss.org/message/UXXVEGHN467GUO4QDP5MNWS56TXTW7BH/

I'll wait to get feedback before making a decision but your PR would be very helpful for a lot of users.

krisgerhard commented 1 year ago

We have used this modification in production for about two weeks now. 🤘 @jmesnil Unfortunately OpenJDK is not equally valuable as the official support for arm based processors is still lacking.

This PR addresses a lot of existing issues and PRs. I'll list some of them.

https://github.com/jboss-dockerfiles/wildfly/pull/68 https://github.com/jboss-dockerfiles/wildfly/issues/155 https://github.com/jboss-dockerfiles/wildfly/issues/149 https://github.com/jboss-dockerfiles/wildfly/issues/148 https://github.com/jboss-dockerfiles/wildfly/issues/128 https://github.com/jboss-dockerfiles/wildfly/issues/108

jmesnil commented 1 year ago

@Henri-Laiho @krisgerhard I've followed up this PR with a change to build JDK 11 and 17 images using the GitHub action in #164

I've pushed the images to my own container registry at https://quay.io/repository/jmesnil/wildfly?tab=tags.

Could you please have a look and run them on ARM (I don't have such hardware at the moment)? If that's ok, we will be able to push them to the official wildfly registry.

Henri-Laiho commented 1 year ago

@jmesnil commits squashed

krisgerhard commented 1 year ago

@Henri-Laiho @krisgerhard I've followed up this PR with a change to build JDK 11 and 17 images using the GitHub action in #164

I've pushed the images to my own container registry at https://quay.io/repository/jmesnil/wildfly?tab=tags.

Could you please have a look and run them on ARM (I don't have such hardware at the moment)? If that's ok, we will be able to push them to the official wildfly registry.

Verified quay.io/jmesnil/wildfly:26.1.2.Final-1-jdk17 from ourside. Seems to work as expected on both AMD and ARM architectures.

Thank you! 🤘

jmesnil commented 1 year ago

We're almost there. I've opened https://github.com/wildfly/wildfly.org/pull/369 to communicate on the changes and will merge the PRs soon...

jmesnil commented 1 year ago

@Henri-Laiho thanks!