search

jboss-fuse / application-templates

Application Templates for Fuse Integration Services
Apache License 2.0
36 stars 67 forks source link

Jira SO-53: Remove non-groupified API from jboss-fuse/application-templates #217

Closed fbm3307 closed 2 years ago

fbm3307 commented 2 years ago

Non-groupified APIs were deprecated in OCP 4.7.

This PR only handles the imagestreams/Templates which are bundled in OpenShift. If any of the other imagestreams or templates are meant to still be used, they should also be similarly updated. A complete API list is available at https://docs.openshift.com/container-platform/4.10/rest_api/index.html .

Signed-off-by: Feny Mehta fbm3307@gmail.com

fbm3307 commented 2 years ago

/assign @yselkowitz

yselkowitz commented 2 years ago

Templates contain subsidiary objects which themselves have apiVersions which also need to be updated, e.g. Route v1 => route.openshift.io, etc. Only those listed here as core/v1 should remain v1 here, all others should be updated accordingly.

fbm3307 commented 2 years ago

/cc @yselkowitz Updated the PR accordingly

yselkowitz commented 2 years ago

ping @cunningt @tadayosi

tadayosi commented 2 years ago

Looks good to me, but master is not maintained. @cunningt Should we port this to 2.1.x.sb2.redhat-7-x?

yselkowitz commented 2 years ago

Ultimately, we need this in the GA branch, how should we go about getting this in there (directly, or indirectly)?

fbm3307 commented 2 years ago

ping @cunningt @tadayosi