search

jboss-fuse / fuse-apicurito-generator

Fuse Apicurito Generator
5 stars 14 forks source link

fix: ensure that the generated Spring XML DSL is valid #28

Closed zregvart closed 5 years ago

zregvart commented 5 years ago

Fixes #27

zregvart commented 5 years ago

I fixed some formatting issues (tab -> space), hope that's OK. When reviewing you might want to ignore whitespace changes.

bfitzpat commented 5 years ago

Will take a look -- thanks @zregvart !

bfitzpat commented 5 years ago

I got some build errors locally with the versions you specified. @cunningt is working on updating the versions more automatically, but has a different set of versions here that seem to work for me locally (https://github.com/jboss-fuse/fuse-apicurito-generator/pull/29).

But other than that, with local testing -- the project I created with your indent/spaces fixes looks awesome. Thanks for that!!

zregvart commented 5 years ago

@bfitzpat I've removed the versions upgrade, the CI job now fails, the version 3.5.33.fuse-720024 of io.fabric8:fabric8-maven-plugin doesn't exist (any more) in JBoss EA repository, a 7.2.x version doesn't seem to exist in the Red Hat GA Maven repository (7.1.x is 3.5.33.fuse-710023-redhat-00002 if I parse the versions right). For 7.3.x there is an early access version (3.5.33.fuse-730010).

bfitzpat commented 5 years ago

Yup. Sounds about right. Tom is still working on getting the versions to sync up with upstream builds, so we'll get this in as soon as we get that working. Thanks @zregvart !

bfitzpat commented 5 years ago

@zregvart If you rebase this PR, I think we can merge it now that https://github.com/jboss-fuse/fuse-apicurito-generator/pull/29 was successfully merged and built. Thanks for the PR!