jboss-fuse / fuse-apicurito-generator

Fuse Apicurito Generator
5 stars 14 forks source link

Automated version synchronization #29

Closed fusesource-ci closed 5 years ago

cunningt commented 5 years ago

@apupier @bfitzpat @EricWittmann : For the Fuse 7.3 build, we have a job that automatically spits out PRs based on the versions that we build in the dev builds, so that we can keep the product branches up to date. This is an example of the output from that.

Does this look reasonable / useful? The builds that it refers to are on the ea repository - I'm not sure what the error was here, but I'm guessing that was the issue?

EricWittmann commented 5 years ago

The idea seems pretty reasonable to me. Would be nice to automate the fuse version change. So +1 from me, assuming it works. :) I'm not quite sure what went wrong with the build, but it doesn't seem to be an issue with the Fuse dependencies:

Downloaded from central: https://repo.maven.apache.org/maven2/org/sonatype/sisu/sisu-guice/3.2.5/sisu-guice-3.2.5-no_aop.jar (400 kB at 482 kB/s)
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-compat/3.3.1/maven-compat-3.3.1.jar (287 kB at 346 kB/s)
[WARNING] Error reading service account token from: [/var/run/secrets/kubernetes.io/serviceaccount/token]. Ignoring.
[WARNING] Error reading service account token from: [/var/run/secrets/kubernetes.io/serviceaccount/token]. Ignoring.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 06:52 min
[INFO] Finished at: 2018-12-04T03:25:01Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.jboss.redhat-fuse:fabric8-maven-plugin:7.3.0.fuse-730007:resource (fmp) on project fuse-apicurito-generator: Execution fmp of goal org.jboss.redhat-fuse:fabric8-maven-plugin:7.3.0.fuse-730007:resource failed: Failed to parse ipAddresskubernetes.default.svc: Unknown host kubernetes.default.svc: Name or service not known -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
cunningt commented 5 years ago

@EricWittmann I don't know if it makes sense or not, but we chose automatic generation of the PRs as a sane compromise between not being forced to take a version change if there's some reason not to take them and being up to date.

I think we're talking about reviewing one of these once a week or once every two weeks - the PRs are generated off a static branch name, so if we run multiple builds, it isn't going to generate multiple version change PRs, an existing PR will just get updated, and you can review it when you get a chance.

I'll take a look at the errors.

cunningt commented 5 years ago

The issue here looks like an issue with kubernetes-client ...

https://github.com/fabric8io/fabric8-maven-plugin/issues/1389

It looks like there's a commit to fix this, I'm going to see if we can cherry-pick it over to our kubernetes-client product branch and then rebuild / re-PR. Don't close or merge, this PR will get updated.

EricWittmann commented 5 years ago

OK sounds good.

cunningt commented 5 years ago

@EricWittmann @bfitzpat It looks like the fix to kubernetes-client fixed the f-m-p error, and the versions have been updated to the most recent build.

EricWittmann commented 5 years ago

Excellent - shall I go ahead and merge?

cunningt commented 5 years ago

@EricWittmann Merge away!

bfitzpat commented 5 years ago

Went ahead and merged!