Closed cunningt closed 6 years ago
These changes need accompanying changes from fabric8 here
@nicolaferraro Added the postgresql dependency. We can depend on the redhat-fuse BOM for the version of postgresql to bring in, that's being brought in by the includes on spring-boot-dependencies -> fabric8-camel-spring-boot -> redhat-fuse.
Have you added it recently? I'm testing with 7.1.0.fuse-710014
and it seems not to be there. Btw in which repo are latest releases published?
@nicolaferraro I added the postgres dependency back to the PR. I've been stalled by build failures in fabric8 and in fuse-components from getting out a 7.2 build
Here's the most recent build in 7.1 - http://origin-repository.jboss.org/nexus/content/groups/ea/com/redhat/fuse/quickstarts/spring-boot-camel-xa/
I don't think it has rebuilt because nothing in spring-boot-camel-xa changed
Does this PR look okay now with the inclusion of the postgres dep?
@cunningt from a project point of view I see no issues, but you've removed the version information from the postgresql dependency and I don't see postgresql in the fuse spring-boot BOM.
That's why I think the build would fail if we merge this.
@nicolaferraro fabric8 is pulling in postgresql version from spring-boot-dependencies: https://github.com/jboss-fuse/fabric8/blob/3.0.11.redhat-7.x/pom.xml#L1324 (sorry, I had that in a PR but hadn't merged that yet)
I tested it with SNAPSHOTs locally and this seems to work okay - it built and mvn dependency:tree reported the correct version of postgresql.
Ok!
https://issues.jboss.org/browse/ENTESB-9274