jboss-fuse / wsdl2rest

A tool allowing quick migration from existing JAX-WS services to REST
Apache License 2.0
25 stars 22 forks source link

Disable automated merge of PR after successful PR build to enable more robust code reviews #78

Open bfitzpat opened 5 years ago

bfitzpat commented 5 years ago

We encountered a small hiccup when dealing with https://github.com/camel-tooling/generator-camel-project/pull/38. As soon as the PR was marked "ok to test" and built successfully without errors, another automated process swooped in and merged the PR though a second review pass was in flight and two additional comments were noted for possible fixes to the code introduced.

Instead of an automated process, we might recommend making the merge a manual one? Or at the very least bumping up the time between a successful PR build and the automated merge (perhaps 24 hours?).