Removed EAP 7.1 tech preview tag

[dak1n1]

The tech preview image no longer exists in registry.access, so remove the TP tag to prevent errors.

[dak1n1]

We're hitting this in Dedicated, which means other customers are likely to hit it too.

[root@ded-int-aws-master-250b2 ~]# oc get is -n openshift jboss-eap71-openshift
NAME                    DOCKER REPO                                                        TAGS            UPDATED
jboss-eap71-openshift   docker-registry.default.svc:5000/openshift/jboss-eap71-openshift   1.1,TP,1.0-TP   5 days ago
[root@ded-int-aws-master-250b2 ~]# oc describe is -n openshift jboss-eap71-openshift
Name:                   jboss-eap71-openshift
Namespace:              openshift
Created:                5 days ago
Labels:                 <none>
Annotations:            openshift.io/display-name=Red Hat JBoss EAP 7.1
                        openshift.io/image.dockerRepositoryCheck=2018-05-30T18:00:29Z
                        openshift.io/provider-display-name=Red Hat, Inc.
                        version=1.4.8
Docker Pull Spec:       docker-registry.default.svc:5000/openshift/jboss-eap71-openshift
Image Lookup:           local=false
Unique Images:          1
Tags:                   3

1.1 (TP)
  tagged from registry.access.redhat.com/jboss-eap-7/eap71-openshift:1.1

  JBoss EAP 7.1 S2I image.
  Tags: builder, eap, javaee, java, jboss, hidden
  Supports: eap:7.1, javaee:7, java:8
  Example Repo: https://github.com/jboss-developer/jboss-eap-quickstarts.git

  * registry.access.redhat.com/jboss-eap-7/eap71-openshift@sha256:e8250ef60f2936e631da0c1c0f1f6b6e3dc118f6bfc46e605148e52edb24d158
      5 days ago

1.0-TP
  tagged from registry.access.redhat.com/jboss-eap-7-tech-preview/eap71-openshift:1.0

  JBoss EAP 7.1 Tech Preview.
  Tags: builder, eap, javaee, java, jboss, hidden
  Supports: eap:7.1, javaee:7, java:8
  Example Repo: https://github.com/jboss-developer/jboss-eap-quickstarts.git

  ! error: Import failed (InternalError): Internal error occurred: unknown: Not Found
      2 hours ago

[dinhxuanvu]

@rcernich Hey Rob. Would you mind taking a look at this issue?

[rcernich]

https://issues.jboss.org/browse/CLOUD-2594

[dak1n1]

@sdodson What can we do to get this imagestream update into openshift-ansible soon? I thought fixing it upstream was the way to go, but it's taking a long time and Dedicated upgrades will be blocked without a workaround. (I can do the workaround, but I wanted to make sure the root cause would also be fixed.)

[sdodson]

@sdodson What can we do to get this imagestream update into openshift-ansible soon? I thought fixing it upstream was the way to go, but it's taking a long time and Dedicated upgrades will be blocked without a workaround. (I can do the workaround, but I wanted to make sure the root cause would also be fixed.)

We really just import content from upstream sources. I'd rather not alter openshift-ansible if upstream hasn't been updated.

[dak1n1]

@sdodson got it. I'll continue working around it on the Online side. Thanks!

[luck3y]

PR for this is here: https://github.com/jboss-openshift/application-templates/pull/459

Sorry this is causing you guys extra work, let me know if you have other pain points like this and I'll try and get them resolved ASAP.

[dak1n1]

@luck3y Thanks! Will do. There are no other issues I'm aware of. We have some new error-checking during imagestream installation that will warn us of any errors after the imagestreams are created. This might be helpful in case you have automated tests that check the imagestreams:

defaults.yml:

osotis_verify_query: "{% raw %}{{ range .items }}{{ $isname := .metadata.name }}{{ if .status }}{{ range (index .status.tags) }}{{if .conditions}}{{ $isname }}{{\" \"}}{{ .conditions }}{{ \"\n\" }}{{end}}{{end}}{{end}}{{end}}{% endraw %}"

tasks.yml:

- name: Check for errors in image imports
  command: "oc get is -n openshift --template={{ osotis_verify_query|to_json }}"
  register: import_errors
  until: "import_errors.stdout_lines|count == 0"
  retries: 6
  delay: 20
  changed_when: false

- name: Fail if there are any image import errors
  fail:
    msg: "The following errors were found during image import\n {{ import_errors }}"
  when:
    - import_errors.stdout_lines is defined
    - "import_errors.stdout_lines|count > 0"