search

jboss-openshift / application-templates

OpenShift application templates supporting JBoss Middleware based applications.
Apache License 2.0
153 stars 303 forks source link

CLOUD-2467 JDG 7.2 templates #455

Closed slaskawi closed 6 years ago

slaskawi commented 6 years ago

https://issues.jboss.org/browse/CLOUD-2467

slaskawi commented 6 years ago

@rcernich @goldmann @osnipso @ryanemerson PTAL

ryanemerson commented 6 years ago

@slaskawi For the mysql and postgres templates we need to add an option for the user to set the "REST_STORE_AS_STRING" parameter as part of CLOUD-2395. Are you ok to add this as part of this PR? Or shall I just issue a new PR once this has been merged?

slaskawi commented 6 years ago

@ryanemerson Yeah, let's add this in this PR... I'll update it in a minute. Stay tuned...

slaskawi commented 6 years ago

@ryanemerson Added changes we discussion on IM.

ryanemerson commented 6 years ago

Thanks @slaskawi, LGTM.

Crumby commented 6 years ago

@ryanemerson Do we really need "REST_STORE_AS_STRING" parameter in templates? Templates itself will create whole new database with empty table to which Data Grid will connect to. So ensuring db backward compatibility in this place seem inappropriate.

ryanemerson commented 6 years ago

@Crumby The issue this is trying to resolve is based upon your "Steps to reproduce" section in CLOUD-2395. Which I was thinking was a template issue, but I guess in that scenario you are simply changing the image not the template.

Crumby commented 6 years ago

@ryanemerson Correct.

ryanemerson commented 6 years ago

Maybe we should remove that commit after all. @slaskawi Any thoughts? and sorry for the unnecessary effort

slaskawi commented 6 years ago

@Crumby @ryanemerson I guess @Crumby is right about installing a fresh DB in the template. Perhaps we should remove CLOUD-2395 JDG 7.2 to 7.1 compatibility settings commit from this PR and make sure this setting is properly documented in some kind of upgrade guide or release notes? If you both agree, I'll update the PR.

slaskawi commented 6 years ago

A note to myself - we should use https://issues.jboss.org/browse/CLOUD-2389 JIRA for templates.

rcernich commented 6 years ago

I think it would be better to collocate these with the image source. Eventually, we will be migrating all the templates into product specific repositories. This has already started for JDV and business automation, e.g. https://github.com/jboss-container-images/jboss-datavirt-6-openshift-image/tree/datavirt64-dev/resources/openshift

slaskawi commented 6 years ago

@rcernich Since we are quite late in the image build loop, may I propose to push them here for now and create a ticket (1) for migrating them to JDG repo in Spring 19? I don't want to rush this too much as I'm pretty sure some OpenShift installer and/or OpenShift Online scripts for deploying templates will need to be updated as well.

(1) May I ask you to add this to Sprint 19 during a planning/grooming session https://issues.jboss.org/browse/CLOUD-2571

slaskawi commented 6 years ago

Closing in favor of https://github.com/jboss-openshift/application-templates/pull/456

rcernich commented 6 years ago

@slaskawi putting them in the jdg repo gives you more control over this. Also, everything defined in this project needs to move through cloud enablement sprints and any exceptions may potentially affect other product releases (i.e. require more coordination, hence being part of the ce sprints).

rcernich commented 6 years ago

Regarding the OSO and OCP installers, you will need to submit PRs to the appropriate repositories (another reason for separating these, as you won't be tied to releases of application-templates).