search

jboss-openshift / application-templates

OpenShift application templates supporting JBoss Middleware based applications.
Apache License 2.0
153 stars 303 forks source link

Jira SO-19: Remove non-groupified APIs in openshift/library templates #501

Open fbm3307 opened 2 years ago

fbm3307 commented 2 years ago

This PR only handles the imagestreams/Templates which are bundled in OpenShift. If any of the other imagestreams or templates are meant to still be used, they should also be similarly updated. A complete API list is available at https://docs.openshift.com/container-platform/4.10/rest_api/index.html

Signed-off-by: Feny Mehta fbm3307@gmail.com

fbm3307 commented 2 years ago

/cc @yselkowitz

yselkowitz commented 2 years ago

LGTM, but my question is how many of these are actually still supported. AMQ 6.3 still is, but that means 6.2 should not be. Data Grid 7.1 has been supplanted by 7.3 (which is now in maintenance support with 8.y being operator-based). EAP 6.4 is about to go into ELS 2 meaning there will be no further updates, and 7.0/7.1 have been supplanted by 7.4. Therefore, some or all of these (except for amq63) could simply be removed from OCP4 in openshift/library. Hopefully the maintainers here can provide some guidance.

yselkowitz commented 2 years ago

So there is agreement to remove the old versions here, but we still need amq63 fixed, which will also require a new tag here.

yselkowitz commented 2 years ago

@fbm3307 could you modify this PR to only fix the amq63 files? The others are being dropped, so there is no reason to modify them.

fbm3307 commented 2 years ago

@yselkowitz changed it

yselkowitz commented 2 years ago

@fbm3307 just discovered that AMQ 6.3 is not supported on OCP 4: https://access.redhat.com/articles/310613

Therefore, I think we can just close this and merge https://github.com/openshift/library/pull/323 instead.