search

jboss-openshift / cct_module

CEKit modules shared by OpenShift container images
Apache License 2.0
45 stars 79 forks source link

[OPENJDK-100] set networkaddress.cache.negative.ttl=0 #385

Closed jmtd closed 3 years ago

jmtd commented 3 years ago

Set a system property so that we do not cache negative DNS responses for any length of time. This can interact badly with short-lived DNS names. We can expect DNS caching to take place at the OpenShift layer anyway.

https://issues.redhat.com/browse/OPENJDK-100

jerboaa commented 3 years ago

I'd suggest adding a test for this feature.

jmtd commented 3 years ago

Does this actually work?

You've shown that no, it doesn't! This was a rush-job, I'm sorry for wasting your reviewer time.

I'd suggest adding a test for this feature.

Very good idea. In fact we should probably try to do this for any change, unless there's good reason not to.

I'll get this fixed up.

jmtd commented 3 years ago

OK the test part is done, pending a merge of https://github.com/jboss-openshift/openshift-examples/pull/39 and correspodning adjustments. It fails at the moment, of course, so next, to set the property properly.

jmtd commented 3 years ago

Hi @jerboaa I think this is now ready to be reviewed again. TIA!